Login | Register  

This site uses DNS Made Easy. Use it for reliable and professional DNS services.

Latest 20 PostsMinimize
19 May 2012 02:00 PM
RE: Socials - Karak
19 May 2012 03:27 AM
16 May 2012 11:10 PM
RE: Socials - Karak
15 May 2012 01:44 PM
15 May 2012 11:26 AM
15 May 2012 09:40 AM
15 May 2012 07:13 AM
15 May 2012 03:37 AM
14 May 2012 08:37 PM
14 May 2012 08:36 PM
14 May 2012 08:00 PM
14 May 2012 09:33 AM
14 May 2012 08:12 AM
14 May 2012 07:19 AM
13 May 2012 11:12 PM
RE: Socials - Karak
13 May 2012 10:32 PM
13 May 2012 10:09 PM
13 May 2012 11:37 AM
13 May 2012 11:03 AM
13 May 2012 07:41 AM
ForumsMinimize
SubThings -> Children
Last Post 22 Jan 2012 07:37 PM byFastalanasa. 4 Replies.
Printer Friendly
  •  
  •  
  •  
  •  
  •  
Sort:
PrevPrev NextNext
You are not authorized to post a reply.
AuthorMessages
KarakUser is Offline
Locutus of WheelMUD
Advanced Member
Advanced Member
Send Private Message
Posts:787
Avatar

--
22 Jan 2012 02:58 PM  

Are we attached to Thing's property name "SubThings" or can we rename it to "Children"?  The meaning might be more obvious to newcomers.

FastalanasaUser is Offline
Grumpy Half-Elf
Veteran Member
Veteran Member
Send Private Message
Posts:1015
Avatar

--
22 Jan 2012 03:07 PM  
Nope, not attached to it. And I agree that Children will be better. That follows Microsoft naming conventions as well.
KarakUser is Offline
Locutus of WheelMUD
Advanced Member
Advanced Member
Send Private Message
Posts:787
Avatar

--
22 Jan 2012 03:32 PM  

Ok, I'll change it in a few minutes.

EDIT: Done.  However, the PlayerDocument equivalent is still named "SubThings" because renaming it broke player loading, so that particular rename should occur in conjunction with a RavenDB database update which I'm not sure how to do offhand ATM.  Fortunately that can wait, and I just slapped a TODO on that property.

KarakUser is Offline
Locutus of WheelMUD
Advanced Member
Advanced Member
Send Private Message
Posts:787
Avatar

--
22 Jan 2012 03:56 PM  

After that, how do you feel about the ...EventArgs being renamed to ...Event? Our events are more than structures so calling them 'args' classes is not only a bit redundant, it's also a bit misleading.

GameEventArgs becomes GameEvent, CancellableGameEventArgs becomes CancellableGameEvent, RemoveChildEventArgs becomes RemoveChildEvent, etc.

FastalanasaUser is Offline
Grumpy Half-Elf
Veteran Member
Veteran Member
Send Private Message
Posts:1015
Avatar

--
22 Jan 2012 07:37 PM  

Sounds reasonable. Make it so. 

You are not authorized to post a reply.

Copyright 2007-2012 by WheelMUD  | Terms Of Use | Privacy Statement
Google Analytics Alternative